quickSettings: Add insertItemBefore() method

The QuickSettings menu currently only support appending items
at the end. Extensions can get around that limitation by accessing
the private grid property to move the item afterwards, but we don't
allow this in our own code.

Expose a new insertItemBefore() method that allows adding an item
before an existing one.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2894>

diff --git a/js/ui/quickSettings.js b/js/ui/quickSettings.js
index 83597c6d454f6c45ac1e956eeb9f61462ac252aa..c684141f757b7003ada7804c72cfbf241cf2fe48 100644 (file)
--- a/js/ui/quickSettings.js
+++ b/js/ui/quickSettings.js
@@ -780,6 +780,15 @@ export const QuickSettingsMenu = class extends PopupMenu.PopupMenu {
 
     addItem(item, colSpan = 1) {
         this._grid.add_child(item);
+        this._completeAddItem(item, colSpan);
+    }
+
+    insertItemBefore(item, sibling, colSpan = 1) {
+        this._grid.insert_child_below(item, sibling);
+        this._completeAddItem(item, colSpan);
+    }
+
+    _completeAddItem(item, colSpan) {
         this._grid.layout_manager.child_set_property(
             this._grid, item, 'column-span', colSpan);